Closed khliland closed 3 years ago
Thanks a lot for the note! Just went ahead and fixed it in #822
@rasbt Do you expect to provide a new release of mlxtend containing this fix in the near future? It would make teaching (using your book) much easier to have a mlxtend version working out of the box with current matplotlib. Particularly in introductory courses it is an advantage if students can just do a straight conda or pip install of packages instead of having to install from Github.
Thanks for the note. I agree that a new release is long overdue. I am currently traveling until September, but I will put that onto my todo list for once I am back. Hoping to get to it some time early September
Thank you for a very useful package and book (Python Machine Learning)!
Describe the bug
matplotlib 3.4.1
no longer accepts the face color parameter'c'
to be an empty string. Inmlxtend
the empty string was used to create circles with transparent face color when highlighting samples, e.g. test data, through the parameterX_highlight
inplot_decision_regions
.Steps/Code to Reproduce
import matplotlib
3.4.1plot_decision_regions
withX_highlight
Suggested fix
Change defaults on line 292 in https://github.com/rasbt/mlxtend/blob/master/mlxtend/plotting/decision_regions.py from:
to
Versions
MLxtend 0.18.0 Windows-10-10.0.18362-SP0 Python 3.7.4 (default, Aug 9 2019, 18:34:13) [MSC v.1915 64 bit (AMD64)] Scikit-learn 0.21.3 NumPy 1.17.2 SciPy 1.3.1 matplotlib 3.4.1