Open lorenzo-stacchio opened 2 years ago
mcnemar
Starting from this line it is described how to obtain an equivalent method to calculate mcnemar exact test.
However, I think that the last line of commented code should be changed with the following one:
p = min(2*p,1.)
otherwise, I believe that you could obtain a p-value greater than 1.
Maybe I am wrong, but using that formula I have obtained a p-value greater than one while using the real implementation no.
Doubt about equivalence in comments in the function
mcnemarin mlxtend.evaluate.mcnemar.py moduleStarting from this line it is described how to obtain an equivalent method to calculate mcnemar exact test.
However, I think that the last line of commented code should be changed with the following one:
p = min(2*p,1.)otherwise, I believe that you could obtain a p-value greater than 1.
Maybe I am wrong, but using that formula I have obtained a p-value greater than one while using the real implementation no.