Open rasbt opened 2 years ago
Hello @rasbt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
mlxtend/feature_selection/columns.py
:Line 119:1: W293 blank line contains whitespace Line 132:5: E303 too many blank lines (2)
mlxtend/feature_selection/generic_selector.py
:Line 29:1: E302 expected 2 blank lines, found 1 Line 38:37: W291 trailing whitespace Line 39:46: W291 trailing whitespace Line 44:70: W291 trailing whitespace Line 216:1: W293 blank line contains whitespace Line 260:80: E501 line too long (80 > 79 characters) Line 261:80: E501 line too long (82 > 79 characters) Line 263:80: E501 line too long (85 > 79 characters) Line 264:80: E501 line too long (86 > 79 characters) Line 414:80: E501 line too long (86 > 79 characters) Line 424:43: W291 trailing whitespace Line 446:44: W291 trailing whitespace Line 501:1: W293 blank line contains whitespace Line 522:1: W391 blank line at end of file
mlxtend/feature_selection/strategy.py
:Line 6:2: W291 trailing whitespace Line 16:22: E128 continuation line under-indented for visual indent Line 17:22: E128 continuation line under-indented for visual indent Line 18:22: E128 continuation line under-indented for visual indent Line 20:1: E302 expected 2 blank lines, found 1 Line 32:40: W291 trailing whitespace Line 45:1: W293 blank line contains whitespace Line 68:80: E501 line too long (80 > 79 characters) Line 69:80: E501 line too long (84 > 79 characters) Line 75:78: W291 trailing whitespace Line 84:80: E501 line too long (81 > 79 characters) Line 131:13: E741 ambiguous variable name 'l' Line 151:80: E501 line too long (98 > 79 characters) Line 155:80: E501 line too long (89 > 79 characters) Line 158:1: W293 blank line contains whitespace Line 172:57: W291 trailing whitespace Line 192:1: W293 blank line contains whitespace Line 199:44: W291 trailing whitespace Line 205:1: W293 blank line contains whitespace Line 240:80: E501 line too long (80 > 79 characters) Line 241:80: E501 line too long (84 > 79 characters) Line 247:78: W291 trailing whitespace Line 256:80: E501 line too long (81 > 79 characters) Line 270:1: W293 blank line contains whitespace Line 277:71: W291 trailing whitespace Line 281:72: W291 trailing whitespace Line 285:1: W293 blank line contains whitespace Line 295:57: W291 trailing whitespace Line 308:43: E261 at least two spaces before inline comment Line 309:80: E501 line too long (99 > 79 characters) Line 310:65: E128 continuation line under-indented for visual indent Line 310:80: E501 line too long (112 > 79 characters) Line 314:43: E261 at least two spaces before inline comment Line 315:80: E501 line too long (96 > 79 characters) Line 316:68: E128 continuation line under-indented for visual indent Line 316:80: E501 line too long (115 > 79 characters) Line 326:1: W293 blank line contains whitespace Line 355:80: E501 line too long (80 > 79 characters) Line 356:80: E501 line too long (84 > 79 characters) Line 364:78: W291 trailing whitespace Line 373:80: E501 line too long (81 > 79 characters) Line 379:54: W291 trailing whitespace Line 407:80: E501 line too long (93 > 79 characters) Line 449:80: E501 line too long (80 > 79 characters) Line 450:80: E501 line too long (84 > 79 characters) Line 458:78: W291 trailing whitespace Line 467:80: E501 line too long (81 > 79 characters) Line 473:54: W291 trailing whitespace Line 501:80: E501 line too long (93 > 79 characters) Line 513:1: W293 blank line contains whitespace Line 516:1: E303 too many blank lines (3) Line 537:80: E501 line too long (80 > 79 characters) Line 543:74: W291 trailing whitespace Line 558:50: W291 trailing whitespace Line 568:47: W291 trailing whitespace Line 588:1: W293 blank line contains whitespace Line 612:1: E302 expected 2 blank lines, found 1 Line 617:40: W291 trailing whitespace Line 635:1: E302 expected 2 blank lines, found 1 Line 641:40: W291 trailing whitespace Line 665:80: E501 line too long (94 > 79 characters) Line 668:1: W293 blank line contains whitespace Line 669:1: E302 expected 2 blank lines, found 1 Line 682:33: E261 at least two spaces before inline comment Line 689:1: W293 blank line contains whitespace Line 690:1: E302 expected 2 blank lines, found 1 Line 703:33: E261 at least two spaces before inline comment Line 740:39: W291 trailing whitespace Line 750:1: W293 blank line contains whitespace Line 761:1: W293 blank line contains whitespace Line 764:33: E261 at least two spaces before inline comment Line 764:34: E262 inline comment should start with '# ' Line 770:39: E261 at least two spaces before inline comment
Line 17:1: W293 blank line contains whitespace Line 18:1: E302 expected 2 blank lines, found 1 Line 26:44: E231 missing whitespace after ',' Line 57:34: E231 missing whitespace after ',' Line 57:36: E231 missing whitespace after ',' Line 67:1: E302 expected 2 blank lines, found 1 Line 71:8: E231 missing whitespace after ',' Line 77:44: E231 missing whitespace after ',' Line 90:8: E231 missing whitespace after ',' Line 96:53: E231 missing whitespace after ',' Line 97:55: E231 missing whitespace after ',' Line 104:1: E302 expected 2 blank lines, found 1 Line 111:1: W293 blank line contains whitespace Line 113:8: E231 missing whitespace after ',' Line 119:53: E231 missing whitespace after ',' Line 120:55: E231 missing whitespace after ',' Line 139:1: W293 blank line contains whitespace Line 140:1: E302 expected 2 blank lines, found 1 Line 144:8: E231 missing whitespace after ',' Line 153:57: E231 missing whitespace after ',' Line 154:59: E231 missing whitespace after ',' Line 155:80: E501 line too long (81 > 79 characters) Line 162:1: E302 expected 2 blank lines, found 1 Line 176:59: E231 missing whitespace after ',' Line 177:61: E231 missing whitespace after ',' Line 178:1: W293 blank line contains whitespace Line 186:1: E302 expected 2 blank lines, found 1 Line 194:69: W291 trailing whitespace Line 195:1: W293 blank line contains whitespace Line 196:1: E302 expected 2 blank lines, found 1 Line 201:80: E501 line too long (112 > 79 characters) Line 209:76: W291 trailing whitespace Line 210:44: W291 trailing whitespace Line 218:1: W293 blank line contains whitespace Line 242:15: E231 missing whitespace after ',' Line 244:1: W293 blank line contains whitespace Line 248:1: E302 expected 2 blank lines, found 1 Line 254:80: E501 line too long (109 > 79 characters) Line 262:75: W291 trailing whitespace Line 263:47: W291 trailing whitespace Line 272:1: W293 blank line contains whitespace Line 295:15: E231 missing whitespace after ',' Line 297:1: W293 blank line contains whitespace Line 301:1: E302 expected 2 blank lines, found 1 Line 307:80: E501 line too long (109 > 79 characters) Line 315:75: W291 trailing whitespace Line 316:47: W291 trailing whitespace Line 325:1: W293 blank line contains whitespace Line 348:15: E231 missing whitespace after ',' Line 350:1: W293 blank line contains whitespace Line 354:1: E302 expected 2 blank lines, found 1 Line 359:80: E501 line too long (121 > 79 characters) Line 367:46: W291 trailing whitespace Line 376:1: W293 blank line contains whitespace Line 412:15: E231 missing whitespace after ',' Line 414:1: W293 blank line contains whitespace Line 418:1: W293 blank line contains whitespace Line 418:1: W391 blank line at end of file
Recreates the PR from #834