Fixes #620 Add a warning about non Boolean inputs

rasbt / mlxtend

A library of extension and helper modules for Python's data analysis and machine learning libraries.

https://rasbt.github.io/mlxtend/

Other

4.83k stars 855 forks source link

Fixes #620 Add a warning about non Boolean inputs #934

Closed NimaSarajpoor closed 2 years ago

NimaSarajpoor commented 2 years ago

Add warning about not bool type. This PR addresses issue #620.

pep8speaks commented 2 years ago

Hello @NimaSarajpoor! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-05-14 18:02:17 UTC

rasbt commented 2 years ago

I just added a Changelog entry. You may have to do a git pull before you make any additional commits. Btw. I just checked out the Deprecation warning, and it works for all three algos. Nice! I think after updating the message, it is good to merge!

NimaSarajpoor commented 2 years ago

@rasbt Thanks for your support and guidance! I thinks things should be good now.

I did not know that I should have added this small change to CHANGELOG.md. So, if I understand correctly, (almost?) any change to this library should be recorded in CHANGELOG.md after they are finalized right before merging the PR.

rasbt commented 2 years ago

No worries and thanks for the PR. Let me run the tests and then I think it should be good to merge