search

rasbt / mlxtend

A library of extension and helper modules for Python's data analysis and machine learning libraries.
https://rasbt.github.io/mlxtend/
Other
4.82k stars 853 forks source link

tests are not passing in the branch `main` #982

Open NimaSarajpoor opened 1 year ago

NimaSarajpoor commented 1 year ago

It seems that the test functions for feature_selection are not passing in the branch main.

I got:

# run in bash: pytest mlxtend/feature_selection/tests/.

####

================= 24 failed, 71 passed, 15 warnings in 34.95s =================
rasbt commented 1 year ago

Huh that's weird. I haven't touched anything recently. It might be due to some recent package updates. Some packages don't have pinned versions and could be the culprit (https://github.com/rasbt/mlxtend/blob/master/.github/workflows/python-package-conda.yml) have to look into that.

rasbt commented 1 year ago

or just to clarify, was it the CI or local testing?

NimaSarajpoor commented 1 year ago

So, if I understand correctly, by "local testing" you meant the testing on just a part of software. Right? If yes, then yeah... it was local testing on feature_selection. I did not check the others.

NimaSarajpoor commented 1 year ago

@rasbt Quick update: I just ran it in another PC and all tests are passing!

But, isn't it weird that I faced such issue in the other PC? I mean... I should have got an error regarding the version of a dependency instead of seeing some tests getting failed. Right?

rasbt commented 1 year ago

@NimaSarajpoor With "local" testing I meant locally on your computer 😅. It's weird that it worked on the other machine, but I am also glad to hear that there are no issues there