rasbt / mlxtend

A library of extension and helper modules for Python's data analysis and machine learning libraries.
https://rasbt.github.io/mlxtend/
Other
4.82k stars 853 forks source link

mcnemar(tb, exact=True) returns None as chi2 #990

Closed ftnext closed 1 year ago

ftnext commented 1 year ago

Code of Conduct

Description

mlxtend.evaluate.mcnemar returns None as chi2 when exact=True.

Related issues or pull requests

Fixes #989

Pull Request Checklist

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.43% // Head: 77.45% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (8cae280) compared to base (423d217). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #990 +/- ## ========================================== + Coverage 77.43% 77.45% +0.01% ========================================== Files 198 198 Lines 11165 11165 Branches 1406 1406 ========================================== + Hits 8646 8648 +2 + Misses 2305 2304 -1 + Partials 214 213 -1 ``` | [Impacted Files](https://codecov.io/gh/rasbt/mlxtend/pull/990?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka) | Coverage Δ | | |---|---|---| | [mlxtend/evaluate/mcnemar.py](https://codecov.io/gh/rasbt/mlxtend/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9ldmFsdWF0ZS9tY25lbWFyLnB5) | `100.00% <100.00%> (ø)` | | | [mlxtend/evaluate/tests/test\_mcnemar\_test.py](https://codecov.io/gh/rasbt/mlxtend/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9ldmFsdWF0ZS90ZXN0cy90ZXN0X21jbmVtYXJfdGVzdC5weQ==) | `100.00% <100.00%> (ø)` | | | [mlxtend/evaluate/counterfactual.py](https://codecov.io/gh/rasbt/mlxtend/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9ldmFsdWF0ZS9jb3VudGVyZmFjdHVhbC5weQ==) | `100.00% <0.00%> (+6.89%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rasbt commented 1 year ago

Since this is an internal, non-user facing change, we don't need to update the docs. It looks good to merge! Thanks, again!