search

rasbt / pattern_classification

A collection of tutorials and examples for solving and understanding machine learning and pattern classification tasks
GNU General Public License v3.0
4.15k stars 1.29k forks source link

Correct min/max typo #1

Closed clebio closed 10 years ago

clebio commented 10 years ago

Hi Sebastian,

Thank you for this set of articles. They're awesome. I found this one minor typo as I was working through the feature scaling article. Also, on your blog itself (but not in this iPython notebook), there seems to be some duplication. From 'The effect of standardization on PCA in a pattern classification task' onward, the content appears twice.

That is on this page: http://www.sebastianraschka.com/Articles/2014_about_feature_scaling.html#The-effect-of-standardization

rasbt commented 10 years ago

Thanks a lot, I didn't notice this duplication of the whole section: There must have been something gone wrong with the merging when I arranged around the sections.

But if I don't overlook anything, this .max() ... .max() was intentionally because I want to show that both columns are re-scaled to the min-value 0.0 and and the max-value 1.0 (basically to show that it applies the scaling column-wise on the whole 2D array.

It should print then: " Min-value after min-max scaling: Alcohol=0.00, Malic acid=0.00

Max-value after min-max scaling: Alcohol=1.00, Malic acid=1.00 "

clebio commented 10 years ago

Ah, you're absolutely right. I was thinking that line and the item before were each a 'min/max' statement. I see what you meant though, my mistake.

Glad to help! Thanks again.

rasbt commented 10 years ago

Thanks, again, I really appreciate your time for taking a look at it and letting me know. I am always happy about any sort of suggestion and input! :)