search

rasbt / pyprind

PyPrind - Python Progress Indicator Utility
BSD 3-Clause "New" or "Revised" License
547 stars 65 forks source link

ETA displayed next to ProgressBar #3

Closed taylan closed 10 years ago

taylan commented 10 years ago

I changed the way the ProgressBar was printed on the terminal. Previously, the ProgressBar was printed once, and only the # characters were added into the line.

Now, the whole ProgressBar line is reprinted in each iteration.

rasbt commented 10 years ago

Thanks again for taking the time to write this code to improve the PyPrind module, I really appreciate it. I just tested the progbar ETA feature, but it unfortunately doesn't print the whole progress bar, the time tracking is accurate though. Also, I noticed that the ETA calculation (and maybe the print) slows down the progress tracking enormously. I recorded a video to show you what I mean: http://www.youtube.com/watch?v=BD59NqsvLcA&feature=youtu.be

I am sorry, but I think I want to keep the code ProgBar object slim for performance reasons, and have the ProgPerc object as an alternative for more details statistics.

taylan commented 10 years ago

I understand what you mean. Still, I think a naked progress bar gives too little information to the user about progress. So I still think that ETA would be useful next to the progress bar. Which is why I refactored my previous code so the ProgBar (and ETA) rendering is done more efficiently.

The code is even simpler than before, and it runs without the performance problems. You can still reject this pull request of course. It's up to you. I'm just trying to make a useful library even more useful :smiley:

rasbt commented 10 years ago

Thanks again, it is pretty nice now! I just refactored another method and replaced % binary operators by the format() method. Didn't notice any differences in performance :).

On Feb 15, 2014, at 1:32 PM, Taylan Aydinli notifications@github.com wrote:

I understand what you mean. Still, I think a naked progress bar gives too little information to the user about progress. So I still think that ETA would be useful next to the progress bar. Which is why I refactored my previous code so the ProgBar (and ETA) rendering is done more efficiently.

The code is even simpler than before, and it runs without the performance problems. You can still reject this pull request of course. It's up to you. I'm just trying to make a useful library even more useful

— Reply to this email directly or view it on GitHub.