search

rasbt / pyprind

PyPrind - Python Progress Indicator Utility
BSD 3-Clause "New" or "Revised" License
547 stars 65 forks source link

Carriage return fix #46

Closed cvanelteren closed 3 years ago

cvanelteren commented 3 years ago

Hi

I was using your package but it caused newlines to appear everywhere. I believe there was a carriage return missing in the cached_output

Local tests seem to have fixed the issue now

this was it before image

Best, C

pep8speaks commented 3 years ago

Hello @cvanelteren! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 75:80: E501 line too long (87 > 79 characters)

Comment last updated at 2021-04-18 18:04:11 UTC
rasbt commented 3 years ago

Thanks for the PR. It actually worked fine for me before, but testing your it works fine as well. Might be an OS-related thing (are you using Windows?). Anyways, thanks for the fix!

cvanelteren commented 3 years ago

@rasbt I am running kitty terminal on arch 5.11.2 (if that helps any). It could be kitty issue as it appeared to me on all three common shells (bash, zsh and fish). The carriage return seemed to behave as it should now. Best wishes, C