search

rasbt / python-machine-learning-book

The "Python Machine Learning (1st edition)" book code repository and info resource
MIT License
12.18k stars 4.39k forks source link

Master #29

Closed dreamylch closed 7 years ago

rasbt commented 7 years ago

Hi there, I just noticed your extensive pull request. I really appreciate it that you are taking the time to improve the contents! It would be nice if you could post a brief description of the purpose of the fix since I see many, many (i.e., 69) files that would be changed if I merge this. I think it is about "changing "rate η (eta)" to " $\eta$ (eta)" if I see it correctly, please let me know. There are several ways to fix that, but the probably easiest one would be if you reset your 2 most recent commits and just "stage" this one single file. I.e., applying the change that you made and then doing a git add code/ch02/ch02.ipynb, committing and pushing the change. It would be great if you could send pull requests via a separate topic branch.

rasbt commented 7 years ago

PS: If it is easier for you, please don't hesitate to close this pull request and to open a new one rather than fixing it, I really don't mind :)

rasbt commented 7 years ago

Could you maybe just briefly describe what the Pull request is about/trying to address?

rasbt commented 7 years ago

I assume the pull requests are happening by mistake? I am closing this for now, but I am happy to accept new pull requests; please just let me now their intend.