search

rasbt / watermark

An IPython magic extension for printing date and time stamps, version numbers, and hardware information
Other
893 stars 92 forks source link

Allow setup.py to run without install_requires #70

Closed jamesmyatt closed 4 years ago

jamesmyatt commented 4 years ago

Uses the same technique as setuptools.

e.g. https://github.com/pypa/setuptools/blob/master/setuptools/__init__.py https://github.com/pypa/setuptools/blob/master/setuptools/version.py

See option 5 in https://packaging.python.org/guides/single-sourcing-package-version/

Closes #67 , Includes #68

jamesmyatt commented 4 years ago

@rasbt , this is done now. Note that keeping the Python 2.7 build running required a little extra work.

jamesmyatt commented 4 years ago

@rasbt , can this be merged?

rasbt commented 4 years ago

(Sorry, busy semester. I am behind with notifications etc)

This PR looks great now. Thanks a lot! Will merge!

jamesmyatt commented 4 years ago

Thanks. Can you label this as hacktoberfest-accepted, please? I don't think it's too late 😝

rasbt commented 4 years ago

Sure