rascui / website

A digital homepage of RAS.
https://rascui.tech
5 stars 29 forks source link

Fix the width and height of all the pictures #26

Closed IbraheemHaseeb7 closed 9 months ago

IbraheemHaseeb7 commented 9 months ago

as you can see in the picture given below... some pictures have different height and some have same. We want all the pictures to have exactly the same height just like the one with tick on it

image

Make sure to fix all the pictures using some generic method like object-fit property in CSS

YashM211 commented 9 months ago

Can you assign this one to me

IbraheemHaseeb7 commented 9 months ago

sure go ahead....just submit your PR @YashM211

DevWeb13 commented 9 months ago

Hello,

I've reviewed the issue regarding the inconsistent image heights. I can take care of this and implement the object-fit property in CSS to ensure all images have the same height as the one with the tick mark.

Additionally, I have an alternative solution that might be of interest. I've developed a script that can crop all images to the desired size. Furthermore, it can also convert them to the WebP format (if they aren't already) to enhance performance. This could be beneficial for both consistent presentation and improved loading times.

Please let me know if you'd like me to proceed with this solution or if you have any other preferences.

Best regards, LaReponseDev

IbraheemHaseeb7 commented 9 months ago

@DevWeb13 can you work on webp format and submit your PR with respect to #7 as this issue is already assigned.

08Uzair commented 9 months ago

Please assign this to me i will do this work in 1-2 hrs

DevWeb13 commented 9 months ago

@DevWeb13 can you work on webp format and submit your PR with respect to #7 as this issue is already assigned.

I noticed that issue number 7 was suggested for me to work on the webp format, however, I see that it's already assigned to someone else. Do you still want me to start on it? I want to make sure I'm not stepping on someone else's work or creating duplicates.

Best regards, LaReponseDev

In the end, I decided to go ahead and do it anyway. I hope it meets your expectations. The Pull Request is now awaiting your review.