rase- / zuul-ngrok

An ngrok tunnel implementation for Zuul
10 stars 12 forks source link

Update ngrok to latest in package.json #12

Closed nolanlawson closed 5 years ago

nolanlawson commented 7 years ago

It's up to 2.2.3 now. I found that the current (2.1.8) was throwing errors for me when I tried to use zuul-ngrok (in particular "the tunnel http://mydomain.ngrok.io is already bound to another tunnel session")

phillipj commented 6 years ago

Thanks! A newer version of ngrok also fixed an explosion I just experienced:

- testing: internet explorer @ Windows 2012 R2: 11
/mustache.js/node_modules/lock/index.js:18
    var i = locked[key].indexOf(exec) //should usually be 0
                        ^

TypeError: Cannot read property 'indexOf' of undefined
    at _release (/mustache.js/node_modules/lock/index.js:18:25)
    at /mustache.js/node_modules/lock/index.js:11:7
    at Socket.<anonymous> (/mustache.js/node_modules/ngrok/index.js:100:10)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:597:20)

With ngrok v2.3.0 in place instead of v2.1.8, it worked like a charm.

rase- commented 5 years ago

Sorry for the inactivity here. I just merged another version bumped, should take care of this too!

phillipj commented 5 years ago

Cool, thanks a lot 👍