search

rasendubi / uniorg

An accurate Org-mode parser for JavaScript/TypeScript
https://oleksii.shmalko.com/uniorg
GNU General Public License v3.0
256 stars 24 forks source link

docs(README): update file.contents to file.value #71

Closed Delapouite closed 1 year ago

Delapouite commented 1 year ago

Hi

While discovering this project, I attempted to run the examples in the README.

I was surprised to see they both output undefined.

There must have been an update in the dependency, now that vfile are returned the .value should be logged.

Thanks

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: ee69f0b62805ce9f425b8a8b6929f984185a8761

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rasendubi commented 1 year ago

Oh, you're right. This changed with the release of vfile@5 simultaneously with the ESM migration. Thanks for the fix!