rashid2538 / php-htmldiff

A library for comparing two HTML files/snippets and highlighting the differences using simple HTML.
GNU General Public License v2.0
69 stars 48 forks source link

Issues upgrading to PHP8 #41

Open a4992214 opened 1 year ago

a4992214 commented 1 year ago

Migrating to PHP8 will cause a problem with the use of the class name "Match". Recommend you change the three occurrences to "HtmlDiffMatch".

Line 342 changed to: $matches[] = new HtmlDiffMatch( count( $this->oldWords ), count( $this->newWords ), 0 );

Line 360:

if( count( $match ) != 0 ) {
    $operations[] = new Operation( 'equal', $match->StartInOld, $match->EndInOld(), $match->StartInNew, $match->EndInNew() );
}

changed to

$operations[] = new Operation( 'equal', $match->StartInOld, $match->EndInOld(), $match->StartInNew, $match->EndInNew() );

Line 428 changed to: return $bestMatchSize != 0 ? new HtmlDiffMatch( $bestMatchInOld, $bestMatchInNew, $bestMatchSize ) : null;

Line 432 changed to: class HtmlDiffMatch {