Nice to e-meet you and thanks for your effort on this submission. My name is Olivier and I would like to conduct the feedback via Issues regarding your code challenge.
Keep in mind, this is a bidirectional process, so we would love to hear back from you as well, so please do not hesitate to raise your question/correction in case we missed anything.
If we are aligned on any issue here and you would like to correct them, please go ahead and open a Pull Request per fix, merge it when you feel confident and we will follow up on these fixes 😇
The first issue I noticed is the lack of use of a single pull request for the whole challenge. It might not mean anything to judge your technical/coding skill, but we would like to see more commits more often along with smaller, more focused pull requests.
You will have an opportunity to do so moving forward as we create Issues for you to resolve. I hope you find the process enjoyable. Good luck and happy coding 🤘
Hello Rashik 👋
Nice to e-meet you and thanks for your effort on this submission. My name is Olivier and I would like to conduct the feedback via Issues regarding your code challenge.
Keep in mind, this is a bidirectional process, so we would love to hear back from you as well, so please do not hesitate to raise your question/correction in case we missed anything.
If we are aligned on any issue here and you would like to correct them, please go ahead and open a Pull Request per fix, merge it when you feel confident and we will follow up on these fixes 😇
The first issue I noticed is the lack of use of a single pull request for the whole challenge. It might not mean anything to judge your technical/coding skill, but we would like to see more commits more often along with smaller, more focused pull requests.
You will have an opportunity to do so moving forward as we create Issues for you to resolve. I hope you find the process enjoyable. Good luck and happy coding 🤘