143 fix minishell io stream

rask24 commented 1 week ago

fix #143

Set outstream to stderr
Fix exit stream on EOF

Summary by CodeRabbit

Bug Fixes
- Improved output handling by directing readline function output to the standard error stream.
- Enhanced consistency in exit message display using a dedicated function for standard error output.
Refactor
- Adjusted output methods in the builtins echo functionality to utilize custom library functions for more controlled output.
- Enhanced readability in environment handling functions by introducing local variables for clarity.
- Streamlined error printing functions to simplify code and improve readability.
- Maintained existing logic in the loop, builtins echo, and builtins export functions while focusing on output management improvements.

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes in this pull request focus on modifying the loop function within the loop.c file. The primary alterations include redirecting the output of the readline function to the standard error stream and changing the method used to display the exit message. The exit message is now output using ft_putendl_fd instead of printf. Additionally, the builtins_echo.c file has been updated to replace printf calls with ft_putstr_fd for outputting strings. These adjustments enhance output consistency while maintaining the original logic of the functions.

Changes

File	Change Summary
src/routine/loop.c	Redirected readline output to `stderr` and changed exit message handling to use `ft_putendl_fd`.
src/builtins/builtins_echo.c	Replaced `printf` calls with `ft_putstr_fd` in the `print_args` function.
src/builtins/builtins_env.c	Updated `print_env_entry` to use `ft_printf` instead of `printf`.
src/builtins/builtins_export.c	Minor changes in comments and indentation in `add_complete_env`.
src/builtins/builtins_export_utils.c	Updated `print_a_export` to use `ft_printf` and improved readability.
include/env.h	Updated author attribution and timestamps in the header comments.
src/utils/print_error.c	Refactored error printing functions to use `ft_dprintf` instead of `printf`.

Assessment against linked issues

Objective	Addressed	Explanation
Fix minishell io stream (#143)	✅

Possibly related PRs

#28: The changes in the main PR regarding output handling in the loop function relate to the modifications in src/utils/print_error.c, where error messages are now printed using a custom function, enhancing consistency in output handling.
#55: The updates in the main PR to the loop function's output handling may connect with the changes in src/exec/execute_pipeline.c, where the execution of commands in a pipeline is managed, potentially affecting how output is handled in the context of command execution.
#88: The changes in the main PR regarding the loop function's control flow and output handling may relate to the modifications in src/exec/exec.c, where command execution logic is centralized, impacting how outputs are managed during execution.
#142: The improvements in the main PR for handling input in the loop function may connect with the changes in src/ui/event_hook.c, where signal handling is refined, affecting how user inputs are processed and responded to.
#163: The new function is_empty_input in the main PR enhances input validation, which relates to the changes in the loop function, ensuring that inputs consisting solely of whitespace are handled correctly without causing syntax errors.
#172: The modifications in the main PR to improve input validation in the loop function align with the changes in the loop.c, where lexer validation is enhanced to handle comments appropriately, preventing syntax errors for such inputs.

Suggested reviewers

alex216

🐇 In the loop where we play,
Output streams lead the way.
Errors now to stderr flow,
Exit messages in tow.
Consistency is our delight,
Hopping through code, oh what a sight! 🌟

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/builtins/builtins_env.c	50.00%	0 Missing and 1 partial :warning:

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   74.38%   74.44%   +0.06%     
==========================================
  Files          47       47              
  Lines         769      771       +2     
  Branches      144      144              
==========================================
+ Hits          572      574       +2     
  Misses        172      172              
  Partials       25       25

Flag	Coverage Δ
unittests	`74.44% <87.50%> (+0.06%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/builtins/builtins_echo.c	`94.11% <100.00%> (+0.78%)`	:arrow_up:
src/builtins/builtins_export.c	`62.16% <ø> (ø)`
src/builtins/builtins_export_utils.c	`100.00% <100.00%> (ø)`
src/builtins/builtins_env.c	`55.55% <50.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba2c08a...39bd996. Read the comment docs.

rask24 commented 1 week ago

e2e tests fail on using builtin echo command.

rask24 / minishell