search

rasky / r64emu

Nintendo 64 emulator (written in Rust)
GNU General Public License v3.0
171 stars 14 forks source link

More RSP doc additions #10

Open CQCumbers opened 4 years ago

CQCumbers commented 4 years ago

I've added descriptions of the MPEG instructions (VRNDP, VRNDN, VMULQ, and VMACQ), as well as fixed typos in the pseudo-code for some of the multiply instructions. The MPEG instruction behavior is based on Near's public domain code and PeterLemon's tests.

rasky commented 3 years ago

Hello, thanks for the additions, I'll review them promptly.

It looks like your commits mistakenly revert this commit of mine: https://github.com/rasky/r64emu/commit/73ce551944534d7486afe7052d75e259eb215e8d

Can you please fix it? Thanks

CQCumbers commented 3 years ago

Sorry for not communicating my progress as well as I should, this is my first time using Github's review system. I believe I've addressed your suggestions at this point (unless you've found the description of LTV or another instruction to be inaccurate). Thanks again for reviewing my changes, hopefully this can be merged soon.