search

rasmusjp / umbraco-multi-url-picker

Multi Url Picker for Umbraco 7
MIT License
31 stars 29 forks source link

Fix backoffice error when getByIds is called with no ids #37

Closed kasperhhk closed 6 years ago

kasperhhk commented 9 years ago

This might only be 7.3 and onwards, but it throws a bunch of red errormessages to the backoffice, which is unwanted.

Since the call wouldn't have any effect when the arrays are empty, omitting them entirely should make no difference.

Spijkerboer commented 8 years ago

Lol, I just created the same PR. Sorry about that :)

ronaldbarendse commented 6 years ago

PR #38 is indeed a duplicate, but only has a single commit to fix the issue 🥇

Are these changes still getting merged? The entityResource service doesn't seem to check this (even in the latest Umbraco version), so I would not see any reason why not 👍

rasmusjp commented 6 years ago

Closing since this isn't needed with v2+ and should be fixed in Umbraco Core instead