Added hide query string and target checkboxes

rasmusjp / umbraco-multi-url-picker

Multi Url Picker for Umbraco 7

MIT License

31 stars 29 forks source link

Added hide query string and target checkboxes #76

Closed ronaldbarendse closed 6 years ago

ronaldbarendse commented 6 years ago

This is the PR for issue #75 that adds checkboxes for hiding the query string and target (open in new window or tab) fields in the link picker.

greystate commented 6 years ago

This could just be me not understanding enough about how the built-in dialog works - but I don't see you actually hiding the target property anywhere?

ronaldbarendse commented 6 years ago

The default Umbraco link picker already has the target checkbox and a boolean flag to show/hide this field:

https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web.UI.Client/src/views/common/overlays/linkpicker/linkpicker.controller.js#L25
https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web.UI.Client/src/views/common/overlays/linkpicker/linkpicker.html#L21

greystate commented 6 years ago

But of course :-)

(Totally confirming what I said about myself :-)

Thanks! 👍