Improve lyrics timing for better anticipation

Hi,

First of all, great job with the project! It's awesome! I've been testing it for almost a month and I have some thoughts on how to improve it. I'll create more pull requests focusing on individual issues, but for now, I have a single request: the lyrics should be anticipated slightly to give the reader time to read them, exactly like in the original Apple Music.

I've read the code and noticed that there wasn't an attempt to anticipate the lyrics. After a couple of tests, I've found that an 800ms offset is perfect. I've already modified the code—it's literally a change of four characters. However, this is a hardcoded fix that should be good for everyone.

A simple slider for the offset in the settings would be fantastic, allowing the user to adjust it as they prefer.

Thanks!

Multiplatform/NowPlaying/Lyrics.swift :

private extension NowPlaying.Lyrics {
    func updateLyricsIndex() {
        guard let lyricsKeys = lyricsKeys, !lyricsKeys.isEmpty else {
            setActiveLineIndex(0)
            return
        }

        let currentTime = AudioPlayer.current.currentTime  + 0.8 // 0.8 seconds offset to anticipate slightly the lyrics
        if let index = lyricsKeys.lastIndex(where: { $0 <= currentTime }) {
            setActiveLineIndex(index)
        } else {
            setActiveLineIndex(0)
        }
    }

rasmuslos / AmpFin

Improve lyrics timing for better anticipation #54