search

rasmuslos / AmpFin

Native Jellyfin music player for iOS & iPadOS
Other
158 stars 12 forks source link

Improve transcode #56

Closed gnattu closed 3 months ago

gnattu commented 3 months ago

This fixes the incorrect usage of NWPathMonitor, correctly set the codec as aac when transcoding, and simplified the transcoding profiles.

rasmuslos commented 3 months ago

There is some additional logic in DownloadManager+Helper I think that does essentially the same as the audio player for download bitrate limits. If the previous implementation didn't work it is probably broken, too, can you take a look please?

gnattu commented 3 months ago

That part does not query current network condition so it always uses the fixed bitrate limit, which seems fine to me. The "not working" part is that the server might return a cached transcoding file with a different bitrate limit for this download, but that is not a client issue.

rasmuslos commented 3 months ago

Thanks!