search

rasmuslos / ShelfPlayer

Native Audiobookshelf player for iOS & iPadOS
Other
148 stars 15 forks source link

App crashes signing in #20

Closed gh0sti closed 5 months ago

gh0sti commented 5 months ago

2.1.2 brought back the issue of signing into the app crashes the app. Might be Siri intents?

rasmuslos commented 5 months ago

That could be the case, maybe requesting the permission to enable the Siri integration causes the crash, this is the only thing that is invoked after login

rasmuslos commented 5 months ago

Please try this version, it does not request Siri authorization

ShelfPlayer.ipa.zip

gh0sti commented 5 months ago

That could be the case, maybe requesting the permission to enable the Siri integration causes the crash, this is the only thing that is invoked after login

another app I sideload is provenance using sidestore. When I sideload provenance it will ask me to remove the spotlight and widget app ids

gh0sti commented 5 months ago

Please try this version, it does not request Siri authorization

ShelfPlayer.ipa.zip

yea that fixed signing in and crashing by removing siri auth right away.

gh0sti commented 5 months ago

That could be the case, maybe requesting the permission to enable the Siri integration causes the crash, this is the only thing that is invoked after login

would it make sense to try to see after signing in to your server that a popup appears to allow siri interaction and maybe adding that delay would allow users to sign in turn on siri and then have the app work?

rasmuslos commented 5 months ago

That could be the case, maybe requesting the permission to enable the Siri integration causes the crash, this is the only thing that is invoked after login

another app I sideload is provenance using sidestore. When I sideload provenance it will ask me to remove the spotlight and widget app ids

This should also happen with this app. it is also encouraged, because they will not work as expected.

That could be the case, maybe requesting the permission to enable the Siri integration causes the crash, this is the only thing that is invoked after login

would it make sense to try to see after signing in to your server that a popup appears to allow siri interaction and maybe adding that delay would allow users to sign in turn on siri and then have the app work?

That great, because the same crash occurred in AmpFin, and I did not know it came from this. There is already a popup, but it is provided by the system, and if the app is not signed by a member of the apple developer program the app will crash. I will just remove it in the side loaded version.

gh0sti commented 5 months ago

Makes most sense to have siri intents disabled for sideloaded version of shelfplayer until you can get it in the appstore/testflight. Looking forward to seeing it in the store/testflight soon hope you can get it through. Somehow Prologue dev was able to get his app in the store which is very similar to ShelfPlayer. If you want to update the release ipa to remove siri that will work for us sideloaders.

rasmuslos commented 5 months ago

This release should fix this: https://github.com/rasmuslos/ShelfPlayer/releases/tag/v2.1.3