search

rasmuslos / ShelfPlayer

Native Audiobookshelf player for iOS & iPadOS
Other
148 stars 15 forks source link

Sort by correct series sequence number #22

Closed gh0sti closed 5 months ago

gh0sti commented 5 months ago

I see you added sort by series number however in ABS I have each book in a series starting with 1,2,3 ect. What I'm seeing here is SP is sorting by the first number then proceeding 1,10,11,12,2,20

If we can get the sort by correct that would be great!

image image

gh0sti commented 5 months ago

Here is my sequence ordering on ABS

image

image

gh0sti commented 5 months ago

Something to do with Array sort from a quick search. I remember doing some of that in college but I can't code worth shit anymore.

rasmuslos commented 5 months ago

The sort function now uses localizedStandardCompare, this should fix this https://github.com/rasmuslos/ShelfPlayer/commit/e636e8924999e092a8db57c1653b41655c8cfb1e

gh0sti commented 5 months ago

are you able to push 2.1.4 with this commit added 2.1.3 doesn't have this fix.

rasmuslos commented 5 months ago

I will release a new build in the next few days

gh0sti commented 5 months ago

The sort function now uses localizedStandardCompare, this should fix this https://github.com/rasmuslos/ShelfPlayer/commit/e636e8924999e092a8db57c1653b41655c8cfb1e

That solution did not fix the issue.

rasmuslos commented 5 months ago

Sorry, I forgot to add this function to the series sort function, I added it to all the other ones but not this one

gh0sti commented 5 months ago

Sorry, I forgot to add this function to the series sort function, I added it to all the other ones but not this one

thanks looking forward to the next build to see this resolved.