search

rasmuslos / ShelfPlayer

Native Audiobookshelf player for iOS & iPadOS
Other
148 stars 15 forks source link

[Bug] Sleep timer defaulting to 2 hours no matter which value is selected. #29

Closed tehguitarist closed 5 months ago

tehguitarist commented 5 months ago

This is on the latest version built from source (with the image cache fix being that most recent commit)

the exception to this is end of chapter, which seems to work correctly, though it doesn’t adjust if you skip forward or backwards through the chapter. It stays at the initial value.

I’m also not sure if this is related, or intended, but the clear/increase/decrease dialog also “pulses” in brightness. It also disappears when you choose increase or decrease, that might be intended but a confirmation dialogue, or the ability to increment/decrement by more than a minute at a time may be good.

rasmuslos commented 5 months ago

Most things should be fixed here: https://github.com/rasmuslos/ShelfPlayer/commit/d3991ab20b18787aee68c51abf6d83d1e4c2cd1b Also what do you mean with "pulses"? Can you share a screen recording? I also wanted to keep the menu on screen after the user increments or decrements the timer, but this is one of those things that's just not possible with SwiftUI for unknown reasons...

tehguitarist commented 5 months ago

Testing it out and looking good (had to do a completely fresh install for it to work, which is fine). Could a solution for the pop up be a +/- buttons to set the time, with a confirmation or cancel button to lock it in? Or is this a “the pop up can only exist for one click” type of silly limitation.

I’ve attached a video of the pulsing below though. Only seems to happen when an audiobook is playing, when it’s paused it’s fine. https://github.com/rasmuslos/ShelfPlayer/assets/28495826/8b8768b5-1971-4884-83d7-b2faefc7842c

tehguitarist commented 5 months ago

Another thing I noticed is that the text box for the time remaining sometimes goes to … instead of the number of minutes or seconds (when the last 59 seconds counts down it becomes most evident) I’ll attach a screenshot below IMG_7732

rasmuslos commented 5 months ago

Testing it out and looking good (had to do a completely fresh install for it to work, which is fine). Could a solution for the pop up be a +/- buttons to set the time, with a confirmation or cancel button to lock it in? Or is this a “the pop up can only exist for one click” type of silly limitation.

I’ve attached a video of the pulsing below though. Only seems to happen when an audiobook is playing, when it’s paused it’s fine. https://github.com/rasmuslos/ShelfPlayer/assets/28495826/8b8768b5-1971-4884-83d7-b2faefc7842c

Actually I was wrong. You can just set menuActionDismissBehavior and it should work.

Another thing I noticed is that the text box for the time remaining sometimes goes to … instead of the number of minutes or seconds (when the last 59 seconds counts down it becomes most evident) I’ll attach a screenshot below IMG_7732

I thought I had addressed this, but apparently not. But it should be an easy fix