Corrections must be implemented - Githubissues

rasnesakam / emakas-shops

0 stars 0 forks source link

Corrections must be implemented #1

Closed rasnesakam closed 1 year ago

rasnesakam commented 1 year ago

https://github.com/rasnesakam/shop-app/blob/3c58057ebdecf144b6639937e28a3cbcf9cc34f9/shop-app.api/Controllers/ProductsController.cs#L61-L62

[x] [HttpGet("{categoryURI}")] must be converted to [HttpGet("Category/{categoryURI}")]
[x] Parameter string categoryURI must be converted to parameters [FromRoute] string categoryUri, [FromQuery] int? page, [FromQuery] int? size

https://github.com/rasnesakam/shop-app/blob/3c58057ebdecf144b6639937e28a3cbcf9cc34f9/shop-app.api/Controllers/ProductsController.cs#L20

[x] [Route("[controller]/[action]")] must be converted to [Route("[controller]")]

rasnesakam commented 1 year ago

I am closing this for now. I didn't implemented pagination for the category filtering. Maybe i will