search

raspberrypi-ui / wayfire

2 stars 2 forks source link

pixdecor: Set button default active to false to avoid unitialized usage #2

Closed txenoo closed 12 months ago

txenoo commented 12 months ago

This is generating multiple valgrind stacktraces of unitialized usage at:

https://github.com/raspberrypi-ui/wayfire/blob/master/plugins/pixdecor/deco-button.cpp#L67

so better to have some initialization, but didn't get into wich is better true or false.

spl237 commented 12 months ago

I think it is probably better to set it to true - whenever a decoration is first drawn, it will be for an active window, so you want the active appearance for the button. I'll test it and see if it matters.