raspberrypi / documentation

The official documentation for Raspberry Pi computers and microcontrollers
https://raspberrypi.com/documentation
Creative Commons Attribution Share Alike 4.0 International
5.21k stars 2k forks source link

BCM2711: AUX_MU_LCR_REG Data size field is wrong #2717

Open alloncm opened 1 year ago

alloncm commented 1 year ago

The latest BCM2711 peripherals docs is wrong about the data size parameter.

According to this errata for BCM2835, bit 1 also must be set for 8 bit mode (and not just bit 0 as the docs says). I tested this on my RPi4 and also checked the Linux kernel headers and saw that this parameter is 2 bits wide and contains also options for Data size of 5 and 6 (which the docs never mention).

Thanks!

lurch commented 1 year ago

ping @pelwell for confirmation?

pelwell commented 1 year ago

Yup.

Tavish108 commented 1 year ago

please assign me this

pelwell commented 1 year ago

If you wish to contribute, fork the repo, make the change to your copy, and submit a Pull Request.

lurch commented 1 year ago

The source-code for our PDFs (including the BCM2711 Peripherals datasheet) isn't publicly available.

pelwell commented 1 year ago

Post some alternate wording, then. Anything to help overcome the logjam.

aallan commented 1 year ago

Sorry. In what way is this a blocker for folks? Documentation will get fixed up and pushed out when we get a chance. It's on the list. But fairly low down it, lots of other things going on as you know. If we need to prioritise this fix let me know.