search

raspberrypi / libcamera

Other
223 stars 95 forks source link

Missleading Build Instructions #110

Closed Thenrik404 closed 7 months ago

Thenrik404 commented 7 months ago

This week I tried to build libcamera in a Docker container running ubunut focal on a raspberry pi 5 with bookworm as host. While libcamera build without any errors it was not able to detect any cameras. I wasted two days on troubleshooting until I found out that the the build instructions were the cause. Instead of 

git clone https://git.libcamera.org/libcamera/libcamera.git

shouldn't it be this???

git clone https://github.com/raspberrypi/libcamera.git

It would be great if you could update this line not only in the Readme.md but also on the official getting started as this is the link users get lead to by the Official Raspberry Pi Camera Software Documentation

The problem gave me headaches because the preinstalled binaries worked on bookworm but no cameras were detected when I was using the source-build on docker (with the (wrong?) link). This lead me to the false assumption that my issue was docker-related. Using the latter clone command allowed me to use the cameras in from the source-build library.

naushir commented 7 months ago

This repo is a fork of the upstream libcamera repo (https://git.libcamera.org/libcamera/libcamera.git). As such, the top level README.rst file follows instructions for building off the upstream tree.

At present the two trees have diverged because we are still waiting to push Pi 5 support upstream. So you can only build Pi 5 support with this tree until then. The intention is that eventually (hopefully in the next few weeks), Pi 5 support will make it upstream, and you can build for Pi 5 using either tree and the instructions you followed.

I am reluctant to change the README.rst file as this is an upstream file, and we don't want to diverge our trees any further going forward as this increases our maintainence burden. Hope this explains the situation better.

Thenrik404 commented 7 months ago

Thank you for your detailed answer, that explains a lot! :) I am looking forward for the pi5 support to finally go upstream. Until then, I hope that others find this thread useful.