search

raspberrypi / libcamera

Other
223 stars 95 forks source link

16-bit endian swap + Black level fixes #121

Closed naushir closed 6 months ago

naushir commented 6 months ago

@davidplowman can you check the black level commit logic and see if you think it makes sense?

davidplowman commented 6 months ago

Things have swapped round a bit, but I think it looks OK. I take it there's no attempt (yet?) to set the FE black level to zero (so that it does nothing) but allow a non-zero black level in the BE?

naushir commented 6 months ago

I take it there's no attempt (yet?) to set the FE black level to zero (so that it does nothing) but allow a non-zero black level in the BE?

No, that's something we do want to add, but I left this change pisp specific for now. The separating out the BL in FE/BE will need an algorithm change that probably wants to go through the mailing list?

naushir commented 6 months ago

Now merged manually.