search

raspberrypi / libcamera

Other
223 stars 95 forks source link

ipa: rpi: pisp: Fix pipeline configuration errors when sharpening dis… #91

Closed davidplowman closed 10 months ago

davidplowman commented 10 months ago

…abled

Output images are showing strange speckles in certain places when sharpening is disabled (such as in uncalibrated.json). This is caused by continuing to run the False Colour block but without the YCbCr conversion and inverse block enabled.

Fix it by always enabling those YCbCr conversion blocks. We need them for all colour sensors where we enable False Colour suppression. We also want them for mono sensors where sharpening is enabled (which in reality will probably be all of them). Given that it's harmless even in any remaining corner cases, it's easier simply to enable these blocks permanently.

naushir commented 10 months ago

This has been rolled into the IPA change.