search

raspberrypi / linux

Kernel source tree for Raspberry Pi-provided kernel builds. Issues unrelated to the linux kernel should be posted on the community forum at https://forums.raspberrypi.com/
Other
11k stars 4.95k forks source link

Please include hid-bigbenff.c driver #2690

Closed hzulla closed 5 years ago

hzulla commented 5 years ago

Hi there,

my driver submission has just been accepted for the upcoming 4.20 mainline kernel by the input maintainers: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/commit/?h=for-4.20/bigbenff&id=256a90ed9e46b270bbc4e15ef05216ff049c3721

The BigBen Interactive PS3OFMINIPAD kids' gamepad is a Playstation3 accessory and was designed for smaller hands. Linux didn't support its rumble effects, so the device's HID protocol needed to be reverse-engineered to write this driver.

I wrote this driver for the Pi. As Retropie is one of the projects my kids use with the Raspberry Pi, please include this driver for the Pi's kernel. The patch applies cleanly on 4.14 with no changes, so there's no backporting to do.

Thank you.

pelwell commented 5 years ago

The corresponding config change (CONFIG_HID_BIGBEN_FF=m) just builds the 9KB module.

Any objection to me merging the driver and config patch, @popcornmix?

pelwell commented 5 years ago

Cool - no objection. Merged.

hzulla commented 5 years ago

Thank you!