search

raspberrypi / linux

Kernel source tree for Raspberry Pi-provided kernel builds. Issues unrelated to the linux kernel should be posted on the community forum at https://forums.raspberrypi.com/
Other
11.19k stars 5.02k forks source link

Enable Raspberry Touch 2 rotation with overlay #6480

Closed foonerd closed 2 days ago

foonerd commented 2 days ago

The panel-ilitek-ili9881c.c which Touch Display 2 is based on already contains orientation. By minor update to the vc4-kms-dsi-ili9881-7inch-overlay.dts panel can be rotated with minimal effort.

Issue opened here: https://github.com/raspberrypi/documentation/issues/3923

Complete discussion and working dbto in the community thread: https://community.volumio.com/t/guide-official-raspberry-touch-display-2/69791

6by9 commented 2 days ago

Commits should include a commit text and Signed-off-by: line., but otherwise looks reasonable.

foonerd commented 2 days ago

@6by9 For my benefit, the commit line should be: dtoverlays: Enable Raspberry Touch 2 rotation

Did I get this right?

Who should be listed as "Signed-off-by: "?

6by9 commented 2 days ago

The patches get applied to the tree exactly as they are presented in the PR. The 3 changes therefore want to get squashed into one, and force pushed (git push -f ...) to your Github branch.

foonerd commented 2 days ago

I see. Lets close this PR and open another, correct one. - Do you agree?

pelwell commented 2 days ago

No - if the end result is one patch then we can squash at the point of merging.

foonerd commented 2 days ago

Thanks. In such case, is there anything else needed from me at this point?

pelwell commented 2 days ago

I think we're good - I'll just give it the once over then merge.