search

raspberrypi / noobs

NOOBS (New Out Of Box Software) - An easy Operating System install manager for the Raspberry Pi
http://www.raspberrypi.org/downloads
2.21k stars 433 forks source link

Align United Arab Emitates language file name to locale standards #573

Closed bovirus closed 4 years ago

bovirus commented 4 years ago

@XECDesign

I propose for _recoveryae.ts to rename this file as recovery_ar_AE.ts and modify it inside as

language="_arAE" sourcelanguage="en"

and modify the recovery.pro to use recovery_ar_AE.ts

to follow the standard https://lh.2xlibre.net/locales/

XECDesign commented 4 years ago

We don't have a recovery_ae.ts, but language="ae" in translation_ar.ts is probably wrong. Is there any reason to use recovery_ar_AE.ts instead of translation_ar.ts if we are not dealing with multiple variants of scripts and/or language?

bovirus commented 4 years ago

@XECDesign

Right. Now the file name is _recoveryae.ts Then the standard file naming is "_recovery__"+"language code"+".ts" Then in this case language file name should be "_recovery_arAE.ts".

If you run lupdate recovery.pro with "recovery_ar.ts with inside language="ar" report error If you run lupdate recovery.pro with "recovery_ar.ts with inside language="ar_AE" report NO error

lurch commented 4 years ago

AFAICT, as we don't have multiple dialects, it should be okay to stick with just translation_ar.ts ? I think we'd only want to move to recovery_ar_AE.ts if we had a UAE-dialect-specific version of the Arabic translation? (which seems extremely unlikely!)

It's much the same way that we "only" have a translation_fr.ts and not separate translation_fr_FR.ts, translation_fr_CA.ts, translation_fr_CH.ts etc.

On the other hand, I'm not a QT expert :wink:

bovirus commented 4 years ago

@lurch

Arabic United Arab Emitates for Is not a dialet. The Arabic has several declinatiation for different region where you used it.

Please read carefull the list that I posted. https://lh.2xlibre.net/locales/

The standard report that if your use language for United Arab Emitates the language code is not "ar" but is "ar_AE"

If you have only French language you can use "fr" because is master language. If you use French language for Belgium you should use "fr_BE".

But for Arabic you cannot use "ar" for United Arab Emitates because is not master language for Arabic.

@XECDesign

It seems that code for Asturian language could be "es_AST".

XECDesign commented 4 years ago

@bovirus, sorry, but nothing you're saying aligns with what's in the repo, what I'm seeing as output of lupdate or Qt's documentation. I'm happy to update to language="ar" because that makes sense. But I'd need help from @procount or @lurch to confirm the rest.

bovirus commented 4 years ago

@XECDesign

Sorry but I didn't udnerstand when you mentioned that what I told not matcjh with repo. I made the same request to @procount

procount use for pinn these filename

translation_ae.ts translation_ast.ts

You use here for NOOBS

translation_ar.ts translation_ast.ts

Both solution for me (langcode ae/ast for pinn ar/ast for NOOBS) are not in the standard.

In both situation (pinn or NOOBS) if you run now lupdate recovery.pro you got both (in pinn and NOOBS) two errors about ae/ast (pinn) or ar/ast (NOOBS) language code.

If you follow the standard https://lh.2xlibre.net/locales/ and make these changes in NOOBS

---- changes for Arabic

rename _translationae.ts as translation_ar_AE.ts (to follow the file naming scheme translation_xxx.ts) modify in _translation_arAE.ts the string as language="_arAE" sourcelanguage="en" modify recovery.pro file to use recovery_ar_AE.ts

---- changes for Asturian

rename _translationast.ts as translation_es_AST.ts (to follow the file naming scheme translation_xxx.ts) modify in _translation_esAST.ts the string as language="_esAST" sourcelanguage="en" modify recovery.pro file to use recovery_es_AST.ts

you can run lupdate recovery.pro without ANY errors because now language codes are OK.

I tested them in my local repository. Using QT SDK 5.14.1

XECDesign commented 4 years ago

That link relates to glibc and isn't directly related to Qt's locale string. Qt just needs the language code and everything else is optional. It determined the country (if it needs to) based on the language if it's not specified.

If country is not present, or is not a valid ISO 3166 code, the most appropriate country is chosen for the specified language.

From what I gather, the core of the issue for you is that you get errors from lupdate?

What errors do you get? I don't get any either way.

5.14.1 is quite far from what's in buildroot.

bovirus commented 4 years ago

When you run lupdate recovery.pro it didn't recognize "ae"/"ast" as valid country code. ar_AE and es_AST are recognized as valid country code. And it match the documents that I posted,

XECDesign commented 4 years ago

Can you paste the exact output?

bovirus commented 4 years ago

Updating 'translation_ar.ts'... Found 161 source text(s) (0 new and 161 already existing) File .../noobs-master/recovery/translation_ast.ts won't be updated: it contains translation but the target language is not recognized

procount commented 4 years ago

For comparison, this is the output from PINN using lupdate version 4.8.6

Updating 'translation_ae.ts'...
    Found 639 source text(s) (0 new and 639 already existing)
Updating 'translation_ast.ts'...
    Found 639 source text(s) (0 new and 639 already existing)
Updating 'translation_ca.ts'...
    Found 639 source text(s) (0 new and 639 already existing)
XECDesign commented 4 years ago

So ar is fine, but the looks of it.

Some history on why ast is used - https://github.com/raspberrypi/noobs/pull/274#issuecomment-283051087

es_AST would be the Spanish with an invalid ISO 3166 country code.

bovirus commented 4 years ago

"ae" and "ast" are wrong. "ar" don't report error but is for Generic Arabic, "ar_AE" is Arabic for United Arab Emitates then I beleive that it's better.

XECDesign commented 4 years ago

Yes, ae is wrong. ast is wrong, but there is no alternative. ar_AE offers no advantage at this time.

XECDesign commented 4 years ago

For reference, if it comes up again: ast was added in Qt 5.0.0:

https://github.com/qt/qtbase/commit/3791d21f72a4c7035cd1db42c36dbd1dc7efd0f6

lurch commented 4 years ago

Yes, ae is wrong.

Ironically, it looks like that error was introduced by @bovirus :laughing: https://github.com/raspberrypi/noobs/pull/453

bovirus commented 4 years ago

"es_AST" is the right working fix for "ast". "ar_AE" is the right working name for the contents of actual "translation_ar.ts" file. "ar" is Generic Arabic and "ar_AE" is Arabic for United Arab Emitates. The contents of "translate_ar.ts" is Arabic for United Arab Emitates. "translation_ar.ts" contains string not for generic Arabic but for Arabic for United Arab Emitates,

bovirus commented 4 years ago

@lurch

The post was of THREE YEARS AGO. I don't have so much experience as now in QT SDK and in the past no one say nothing different or propose better/different solutions.

procount commented 4 years ago

I should probably change PINN back to using 'ar' then. At least it will be consistent with NOOBS and they can both be wrong. :smile:

AIUI, the current limitation is QT4.8 as it doesn't see those codes as errors, and doesn't even support 'ast', whereas QT5 has better support. So we can re-visit this again when we change to Qt5?

XECDesign commented 4 years ago

We've gone around in circles enough, but one more time:

The format we're using here is ISO639[_ISO3166] . As documented here https://doc.qt.io/archives/qt-4.8/qlocale.html#QLocale-2

es_AST is Spanish from an invalid country code, so Qt will just treat that as Spanish. That's wrong. You don't get an error because the country isn't important, but the language ends up being wrong.

We can use ar_AE when we have Arabic translations from other regions.

XECDesign commented 4 years ago

Also, I can't find any reference to 'generic Arabic' or how it might differ from the Arabic written in UAE.

https://en.wikipedia.org/wiki/Varieties_of_Arabic https://en.wikipedia.org/wiki/United_Arab_Emirates#Languages

lurch commented 4 years ago

"ar" is Generic Arabic and "ar_AE" is Arabic for United Arab Emitates. The contents of "translate_ar.ts" is Arabic for United Arab Emitates. "translation_ar.ts" contains string not for generic Arabic but for Arabic for United Arab Emitates,

@bovirus If you're really that concerned about the differences (I'm afraid I know absolutely nothing about Arabic myself), I suspect a "more appropriate" fix might be to update translate_ar.ts to use "Generic Arabic" rather than "Arabic for United Arab Emirates" ? :man_shrugging:

bovirus commented 4 years ago

@lurch

If the language contents in the file is "Generic Arabic"

language name = translation_ar.ts id = TS version="2.0" language="ar" sourcelanguage="en"

If the language contents in the file is "Arabic for United Arab Emitates"

language name = translation_ar_AE.ts id = TS version="2.0" language="ar_AE" sourcelanguage="en"

lurch commented 4 years ago

Sorry, I meant if you're that bothered about the differences between "Generic Arabic" and "Arabic for United Arab Emirates", then perhaps a better fix for NOOBS is to update the translations inside the translate_ar.ts file to use "Generic Arabic" rather than "Arabic for United Arab Emirates" ? :man_shrugging:

IMHO we should prefer to have "generic" language translations, rather than country-specific language translations.