search

raspberrypi / picamera2

New libcamera based python library
BSD 2-Clause "Simplified" License
892 stars 188 forks source link

[SUGGESTION] Exception checking around ffmpeg subprocess #829

Open cambridgeBlueMan opened 1 year ago

cambridgeBlueMan commented 1 year ago

I note your comment in the program file:

"Because we are prepared to accept whatever parameters and values that FFmpeg supports, there is generally no checking up at this level. That may change over time as we develop better expectations as to what can and cannot work."

I believe this will leave you hostage to fortune over time and there will probably be a need for exception checking around the subprocess which runs ffmpeg?

davidplowman commented 1 year ago

Probably. I think there will have to be a check every time we try and write anything to it to see if it's still behaving, and possibly kill it if it isn't. I know I've discussed this with some folks, and will get round to it, but for the moment we're just in a bit of a make-everything-work-on-a-Pi-5-yesterday zone.

cambridgeBlueMan commented 1 year ago

I can imagine! :)

On Thu, 19 Oct 2023 at 13:17, davidplowman @.***> wrote:

Probably. I think there will have to be a check every time we try and write anything to it to see if it's still behaving, and possibly kill it if it isn't. I know I've discussed this with some folks, and will get round to it, but for the moment we're just in a bit of a make-everything-work-on-a-Pi-5-yesterday zone.

— Reply to this email directly, view it on GitHub https://github.com/raspberrypi/picamera2/issues/829#issuecomment-1770841881, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRULU7TGJU5UJD4ANGD333YAEK7PAVCNFSM6AAAAAA6HBLJZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZQHA2DCOBYGE . You are receiving this because you authored the thread.Message ID: @.***>