search

raspberrypi / pico-examples

BSD 3-Clause "New" or "Revised" License
2.84k stars 820 forks source link

New example for ntp_client with LwIP Socket API #434

Closed gemarcano closed 5 months ago

gemarcano commented 10 months ago

Implemented a new example derived from the existing ntp_client example, but this time using the LwIP Socket API and FreeRTOS NO_SYS=0.

This was requested in raspberrypi/pico-sdk#1540.

This depends on raspberrypi/pico-sdk#1530 to match upstream FreeRTOS changes when they merged SMP support.

I tested this locally by manually enabling USB output and disabling UART.

My own primary criticism is that I implemented everything in a single function. It was easier for me to follow, as we no longer need callbacks. I find the code relatively readable, but it may benefit from someone else deciding if it needs more comments.

peterharperuk commented 10 months ago

Looks great - I'll fix the address printing and then maybe just push it to develop.