search

raspberrypi / pico-examples

BSD 3-Clause "New" or "Revised" License
2.62k stars 779 forks source link

Fix for composite report HIDs. #445

Closed Franticware closed 2 months ago

Franticware commented 7 months ago

There was an extraneous byte in boot mouse report for composite device type mice. In existing code, this was only handled in process_generic_report, not tuh_hid_report_received_cb. This is a fix for that. I also tested it on pi pico and it works fine.

lurch commented 7 months ago

ping @hathach just in case a similar problem affects TinyUSB too?

Franticware commented 7 months ago

ping @hathach just in case a similar problem affects TinyUSB too?

Maybe, is he able to see this PR because he is tagged? It is not obvious to me how to message him here on github.

lurch commented 7 months ago

Sorry, that was a question aimed at the TinyUSB developer, not at yourself Vojtěch :wink: (i.e. I wasn't saying "Should we ping Ha Thach?", I was saying "I'm pinging Ha Thach here (by mentioning his GitHub username), just in case TinyUSB is also affected".)

Franticware commented 6 months ago

@lurch Should I do something to move forward the approval/merge process?

lurch commented 6 months ago

@Franticware Nope, I think the only thing to do at this point is be patient... :slightly_smiling_face:

Franticware commented 2 months ago

I now realize this fix is not good enough. Unfortunately there are other issues (the data passed to tuh_hid_report_received_cb callback by tinyusb is incomplete) and I am not able to fix it at this point.