Why MEMP_NUM_ARP_QUEUE lwIP options is set in lwipopts_examples_common.h if ARP_QUEUEING default value is 0?

raspberrypi / pico-examples

BSD 3-Clause "New" or "Revised" License

2.77k stars 808 forks source link

Open brizzolazzi opened 2 months ago

brizzolazzi commented 2 months ago

MEMP_NUM_ARP_QUEUE seems useful only if ARP_QUEUEING is set to 1, but in https://github.com/raspberrypi/pico-examples/blob/master/pico_w/wifi/lwipopts_examples_common.h is not defined and ARP_QUEUEING default value is 0.

So why MEMP_NUM_ARP_QUEUE is set to 10, while ARP_QUEUEING is not set?

Is this a mistake?

Thanks in advance.

peterharperuk commented 2 months ago

It does no harm. We probably copied this file from elsewhere. It might be worth seeing what difference enabling the feature makes.