search

raspberrypi / pico-extras

BSD 3-Clause "New" or "Revised" License
480 stars 120 forks source link

nonesense message in pico_extras_import.cmake #39

Open smithps opened 2 years ago

smithps commented 2 years ago

Line 53 has the message;

"PICO EXTRAS location was not specified. Please set PICO_EXTRAS_PATH or set PICO_EXTRAS_FETCH_FROM_GIT to on to fetch from git." should it really be;

... PICO_EXTRAS_FETCH_FROM_GIT to fetch from git.

lurch commented 2 years ago

It defaults to being 'off', so you have to set it 'on' to make use of that feature? :shrug: https://github.com/raspberrypi/pico-extras/blob/master/external/pico_extras_import.cmake#L52

smithps commented 2 years ago

It defaults to being 'off', so you have to set it 'on' to make use of that feature? 🤷 https://github.com/raspberrypi/pico-extras/blob/master/external/pico_extras_import.cmake#L52

Ahhhh !!! now the message makes sense. I would suggest phrasing the message as such though; changing the 'on' in the message to 'ON'

PICO EXTRAS location was not specified. Please set PICO_EXTRAS_PATH or set PICO_EXTRAS_FETCH_FROM_GIT to ON to fetch from git.

Perhaps autocorrect somewhere along the line made it lowercase - because of that I didn't read it as intended.

I also misquoted the line number, but I meant the message as quoted above.

JamesH65 commented 2 years ago

I agree with @smithps, changing to "ON" would make that a lot clearer.

lurch commented 2 years ago

Feel free to submit a PR @smithps