raspberrypi / pico-feedback

25 stars 2 forks source link

Mistake in python sdk in the PIO section #368

Closed webdeb closed 7 months ago

webdeb commented 9 months ago

Maybe this is just outdated, but there is no sideset_pins and set_pins argument for @asm_pio decorator. It should be init for both cases.

Bildschirm­foto 2023-12-22 um 04 31 04
lurch commented 9 months ago

Looks like MicroPython must have renamed those parameters? https://docs.micropython.org/en/latest/library/rp2.html#rp2.asm_pio

webdeb commented 9 months ago

@lurch maybe, however, in the other passages of the pdf the author used the correct arg names.

webdeb commented 9 months ago

Oh, forgot to mention, that the StateMachine has also other arg names, sideset_base and set_base

lurch commented 9 months ago

@nathan-contino See also #142

aallan commented 7 months ago

Fixed in the documentation. Will be present in the next release.