sh1106.py: Fix the pin numbers in the example code.

raspberrypi / pico-micropython-examples

Examples to accompany the "Raspberry Pi Pico Python SDK" book.

BSD 3-Clause "New" or "Revised" License

973 stars 222 forks source link

Closed robert-hh closed 3 years ago

robert-hh commented 3 years ago

The pins numbers of the example code in sh1106.py did not match the RP2040 pins. Instead, pin numbers suitable for ESP8266 were listed.

aallan commented 3 years ago

LGTM. @lurch?

lurch commented 3 years ago

I don't have a SH1106 with which to test, but yeah this LGTM :+1:

robert-hh commented 3 years ago

I tested that sample code using a SH1106 with both I2C and SPI settings.

aallan commented 3 years ago

Merged. It'll get pulled into the PDF documentation on the next public release.

lurch commented 3 years ago

(it's only the README.adoc that gets pulled into the PDF documentation, which this PR hasn't modified :wink: )

aallan commented 3 years ago

The code also gets pulled into the PDF. You should remember that, you wrote the scripting. 😄

lurch commented 3 years ago

Oh! I'd forgotten that :laughing: :rofl: :fried_egg: