raspberrypi / pico-project-generator

Tool to automatically generate a Pico C SDK Project
BSD 3-Clause "New" or "Revised" License
297 stars 75 forks source link

bug: Scan for local boards. #60

Closed rewolff closed 1 year ago

rewolff commented 1 year ago

I have set: PICO_BOARD_HEADER_DIRS so that builds will now find my own RP2040 based boards.

It'd be nice if the pico-project-generator would scan the listed directory and add the boards there to the list of available boards.

(not sure how the current list is generated, but that should be generated at runtime from $PICO_SDK/src/boards/include/boards/ ... )

JamesH65 commented 1 year ago

Hi, I think I have already done this, there is a branch with the change, so you are welcome to try it out. In fact, I've been waiting for people to report on it, but nothing so far!

https://github.com/raspberrypi/pico-project-generator/tree/pico-w-support

rewolff commented 1 year ago

Oh.... I'm on the pico-w-support branch, and I didn't see my boards.... So now this turns into a bug report :-)

JamesH65 commented 1 year ago

Hmm, thought I simply scanned the boards folder and displayed the content but I wrote it a couple of months ago so may be misremembering.

JamesH65 commented 1 year ago

Ah, I just scan the SDK's boards folder, not the PICO_BOARD_HEADER_DIRS folder. Mainly because I had not heard of PICO_BOARD_HEADER_DIRS. That is a bug, so please feel free to create a new issue.

rewolff commented 1 year ago

What's wrong with this one? The title that says "feature request" ? I could edit it. Edit: ahh. Markdown doesn't work in titles.

JamesH65 commented 1 year ago

Nothing wrong with this one, Covid brain fart! Just change the title.

JamesH65 commented 1 year ago

This should now be fixed on top of tree master.