search

raspberrypi / pico-project-generator

Tool to automatically generate a Pico C SDK Project
BSD 3-Clause "New" or "Revised" License
289 stars 74 forks source link

SyntaxError in generated settings.json #84

Open paulober opened 1 year ago

paulober commented 1 year ago

The updated settings.json content in the update_vscode_json_to_sdk1_5 branch contains a ) where I should not be. https://github.com/raspberrypi/pico-project-generator/blob/2ab988c000f7d5ded517ca6145845125af45e3fa/pico_project.py#L1240 Also following additional , causes JSON.parse to fail:

SyntaxError: Expected double-quoted property name in JSON at position 247

https://github.com/raspberrypi/pico-project-generator/blob/2ab988c000f7d5ded517ca6145845125af45e3fa/pico_project.py#L1233

lurch commented 12 months ago

Fixed by #85 , so can be closed?

paulober commented 12 months ago

@lurch Yes. Github has not closed it automatically because it waits for the feature branch to be merged into master.