raspberrypi / pico-sdk

BSD 3-Clause "New" or "Revised" License
3.26k stars 840 forks source link

Switch from tinyusb to tinyusb-src #1044

Open sqrtroot opened 1 year ago

sqrtroot commented 1 year ago

Since the tiny usb repo also includes lots of sdks for other modules for their examples. If you do a git submodule update --init --recursive you'll get tons of sdk's you don't need. The maker of tinyusb has a seperate repo: tinyusb-src with only the src code of the project.

We should consider switching the submodule to that repository with the correct commit: https://github.com/hathach/tinyusb_src/tree/1f1e9b3412d3f0abfba90376c8166b0c4e138115

lurch commented 1 year ago

Since the tiny usb repo also includes lots of sdks for other modules for their examples. If you do a git submodule update --init --recursive you'll get tons of sdk's you don't need.

Yup, and that's why we don't suggest doing a recursive clone in our getting started documentation.

kilograham commented 1 year ago

agreed; this makes sense

kilograham commented 1 year ago

@liamfraser since you are updating to the correct 0.14.0 commit anyway

paulhamsh commented 1 year ago

Since the tiny usb repo also includes lots of sdks for other modules for their examples. If you do a git submodule update --init --recursive you'll get tons of sdk's you don't need.

Yup, and that's why we don't suggest doing a recursive clone in our getting started documentation.

The TinyUSB version in the SDK seems old - it seems to be missing Pico-PIO-USB, which is odd for a Pico SDK. I can't work out how to get that without deleting TinyUSB, cloning from github. then doing that fun recursive submodule thing. I don't know git.

Any way to keep the TInyUSB branch up to date in this repo - or via git?

liamfraser commented 1 year ago

Do this as a separate submodule

liamfraser commented 1 year ago

tinyusb-src does not pull in pio usb, so we would have to pull that in somehow

kilograham commented 1 year ago

deferred for now

kilograham commented 1 year ago

yes, we will need to update TinyUSB to allow passing in the location of Pico-pio-usb

shreeve commented 7 months ago

@kilograham, @liamfraser - TinyUSB version 1.6.0 was just released. Would it be possible to update and also fold in the concept in this issue at the same time?