i2c_slave.c, use incorrect define while configuring IC_INTR_MASK register in i2c_slave_init()

raspberrypi / pico-sdk

BSD 3-Clause "New" or "Revised" License

3.68k stars 917 forks source link

i2c_slave.c, use incorrect define while configuring IC_INTR_MASK register in i2c_slave_init() #1536

Closed igor-marinescu closed 2 months ago

igor-marinescu commented 11 months ago

Hello,

In file: src\rp2_common\pico_i2c_slave\i2c_slave.c Function: i2c_slave_init(), line 71;

I2C_IC_INTR_MASK_M_RX_FULL_BITS | I2C_IC_INTR_MASK_M_RD_REQ_BITS | I2C_IC_RAW_INTR_STAT_TX_ABRT_BITS |

While configuring the IC_INTR_MASK register the use of I2C_IC_RAW_INTR_STAT_TX_ABRT_BITS is wrong. Instead I2C_IC_INTR_MASK_M_TX_ABRT_BITS must be used.

Thank you

will-v-pi commented 4 months ago

Linking this to #1613 which fixes this issue

kilograham commented 2 months ago

merged into develop