adc: adc_read() not check for error (#1575) v2 - Githubissues

raspberrypi / pico-sdk

BSD 3-Clause "New" or "Revised" License

3.27k stars 844 forks source link

adc: adc_read() not check for error (#1575) v2 #1599

Open ruehlchris opened 6 months ago

ruehlchris commented 6 months ago

Implementation of adc_read() not check for errors in the ADC_CS register.

change the return type from uint16_t to int32_t
check for ADC_CS_READY_BITS and error ADC_CS_ERR_BITS or ADC_CS_ERR_STICKY_BITS
return the ADC value (12bits) or the negative value of ADC_CS_ERR_BITS or ADC_CS_ERR_STICKY_BITS depending on the error

v2:

update the code, optimize the workflow
no reset required , so removed it.