pico_flash stops including certain unneeded headers

raspberrypi / pico-sdk

BSD 3-Clause "New" or "Revised" License

3.66k stars 911 forks source link

pico_flash stops including certain unneeded headers #1699

Closed jaguilar closed 3 months ago

jaguilar commented 4 months ago

Fixes #1698

kilograham commented 4 months ago

Yeah, we have kitchen_sink test already which pulls in all libraries to make sure they compile, so pls remove the new test

jaguilar commented 4 months ago

@kilograham kitchen_sink_test is already building without my change, however, the test I'm adding is not. I'm still happy to remove it, but I think kitchen_sink_test is hiding the bug by pulling in hardware_exception as a separate dependency. Just wanted to reconfirm that you want it removed even though we have no coverage of the underlying issue already.

kilograham commented 4 months ago

ah good point, but yeah, i think remove it... we should add a separate (hopefully automated) check of each library

jaguilar commented 4 months ago

Updated the state to just remove those three includes. Thank you for taking the time to review.