raspberrypi / pico-sdk

BSD 3-Clause "New" or "Revised" License
3.68k stars 917 forks source link

Incorrect flushing of the SMx_SHIFTCTRL FIFOs #1855

Closed U-alb closed 1 month ago

U-alb commented 1 month ago

Here, https://github.com/raspberrypi/pico-sdk/blob/efe2103f9b28458a1615ff096054479743ade236/src/rp2_common/hardware_pio/include/hardware/pio.h#L1670-L1671 we operate twice on the RX FIFO and I believe that we are supposed to clear both the RX and the TX FIFO

kilograham commented 1 month ago

not a bug ; the code works as is

lurch commented 1 month ago

See #1359 for more detail.