Comment in pico_configure_ip4_address uses wrong definition names

raspberrypi / pico-sdk

BSD 3-Clause "New" or "Revised" License

3.66k stars 911 forks source link

Comment in pico_configure_ip4_address uses wrong definition names #1891

Open mattmyne opened 1 month ago

mattmyne commented 1 month ago

A comment in CMakeLists.txt pico_configure_ip4_address function incorrectly references the CYW43_DEFAULT_IP_AP_ADDRESS compile definition name as CYW43_DEFAULT_AP_IP_ADDRESS.

This should be fixed to avoid user confusion when setting an alternative IP in AP mode.

mattmyne commented 1 month ago

Added PR #1892 that also updates the default station IP definition names, from CYW43_DEFAULT_IP_... to CYW43_DEFAULT_IP_STA_...