search

raspberrypi / pico-setup

92 stars 42 forks source link

Script fails, if the folder pico_setup.sh is downloaded to, has a space in it's name #17

Closed protik09 closed 3 years ago

protik09 commented 3 years ago

For example, I download the script to a folder called "Embedded Projects" and it fails.

pico_setup_error_small

Error: ./pico_setup.sh: line 48: cd: too many arguments

Tried this in WSL (Ubuntu 20.04.2 LTS) and native Linux Mint 20.1 on Cinnamon - it fails in both

I fixed the issues in the script and can send a pull request if needed.

aallan commented 3 years ago

Tried this in WSL (Ubuntu 20.04.2 LTS) and native Linux Mint 20.1 on Cinnamon - it fails in both

The script is designed to run on an up to date installation of Raspberry Pi OS. It is not designed to run on other Linux installations, hence the warning message right at the start "Not running on a Raspberry Pi. Use at your own risk!"

michaelstoops commented 3 years ago

This is also a problem on Raspberry Pi OS:

mstoops@pod-gw ~/the dir/pico-setup
 % ./pico_setup.sh
...
Creating /home/mstoops/the dir/pico-setup/pico
./pico_setup.sh: line 48: cd: too many arguments
mstoops@pod-gw ~/the dir/pico-setup
 % uname -a
Linux pod-gw 5.10.17-v7+ #1403 SMP Mon Feb 22 11:29:51 GMT 2021 armv7l GNU/Linux
mstoops@pod-gw ~/the dir/pico-setup
 % cat /proc/cpuinfo
...
Hardware    : BCM2835
Revision    : a22082
Serial      : 00000000bcfe828d
Model       : Raspberry Pi 3 Model B Rev 1.2
mstoops@pod-gw ~/the dir/pico-setup
 % cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"
aallan commented 3 years ago

Yup, and there is an existing PR to fix this, see #18.

aallan commented 3 years ago

So #18 has been superseded by #20. But note that one of openocd's submodules doesn't handle spaces and there doesn't seem to be a way around that?

lurch commented 3 years ago

But note that one of openocd's submodules doesn't handle spaces and there doesn't seem to be a way around that?

I'm now following that up with the relevant upstream project: https://github.com/msteveb/jimtcl/issues/199